Update framework submodule and tag #395
Conversation
peverwhee
changed the title
peverwhee
changed the title
.gitmodules
Outdated
| url = https://github.com/ESCOMP/atmospheric_physics | ||
| fxtag = bb7c61028c1d6ead2c09b2c58cfbbfb3c3638a51 | ||
| fxtag = e05850ede0571c5c950ed86e4d73e1bab46a348a |
There was a problem hiding this comment.
Just curious why we are not using tags for the atmospheric_physics?
There was a problem hiding this comment.
We don't currently have a rule to use tags in CAM-SIMA I think because it makes things easier while we're in this fast development process.
We will have to revisit this at some point in the future. Maybe once we've finished cam4?
| select case (trim(phys_var_stdnames(name_idx))) | ||
| case ('potential_temperature') | ||
| call read_field(file, 'potential_temperature', input_var_names(:,name_idx), 'lev', timestep, phys_state%theta) | ||
| call read_field(file, 'potential_temperature', input_var_names(:,name_idx), 'lev', timestep, phys_state%thermo%theta) |
There was a problem hiding this comment.
Another question - it appears that we are adding a thermo ddt? Is that correct and if so what are its elements?
There was a problem hiding this comment.
This is a test file that is the expected code generation for this test registry - https://github.com/ESCOMP/CAM-SIMA/blob/development/test/unit/python/sample_files/write_init_files/ddt2_reg.xml
The test registry has a nested DDT and the updates that dustin brought into the framework fix a bug that enables these to be passed in correctly. The old phys_state%theta was actually incorrect.
Hope that makes sense!
Tag name (required for release branches):
Originator(s): peverwhee
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Updates ccpp-framework tag to the latest. Also brings in updated atmospheric_physics hash.
Describe any changes made to build system: N/A
Describe any changes made to the namelist: N/A
List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A
List all files eliminated and why: N/A
List all files added and what they do: N/A
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)M .gitmodules
M test/unit/python/sample_files/write_init_files/physics_inputs_ddt*
M ccpp_framework
M src/physics/ncar_ccpp
If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima: all PASS
derecho/gnu/aux_sima: all PASS
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced: